Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[workspace] Generalize vendor_cxx for multiple uses #17228

Merged

Conversation

jwnimmer-tri
Copy link
Collaborator

@jwnimmer-tri jwnimmer-tri commented May 19, 2022

This enables enables a future qhull commit to use a better technique for C++ symbol visibility. Towards #17231.


This change is Reviewable

@jwnimmer-tri jwnimmer-tri added priority: low status: single reviewer ok https://drake.mit.edu/reviewable.html release notes: none This pull request should not be mentioned in the release notes labels May 19, 2022
@jwnimmer-tri jwnimmer-tri marked this pull request as ready for review May 19, 2022 03:34
@jwnimmer-tri
Copy link
Collaborator Author

+@EricCousineau-TRI for both reviews per schedule, please.

Copy link
Contributor

@EricCousineau-TRI EricCousineau-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: x 2

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all discussions resolved, LGTM from assignee EricCousineau-TRI(platform) (waiting on @jwnimmer-tri)

@EricCousineau-TRI EricCousineau-TRI merged commit e0b3f8c into RobotLocomotion:master May 19, 2022
@jwnimmer-tri jwnimmer-tri deleted the vendor-cxx-mv branch May 19, 2022 13:11
aykut-tri pushed a commit to aykut-tri/drake that referenced this pull request May 27, 2022
aykut-tri pushed a commit to aykut-tri/drake that referenced this pull request Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: low release notes: none This pull request should not be mentioned in the release notes status: single reviewer ok https://drake.mit.edu/reviewable.html
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants