Remove ament and catkin support #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nobody has volunteered to maintain these, so we must remove them from our support footprint.
|
+@BetsyMcPhail for feature review, please. Please cross-check that I found all of the necessary changes / mentions / CI tweaks. |
BetsyMcPhail
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
I don't see any files / instances that you missed. Likewise, all removed files make sense.
Reviewed 37 of 37 files at r1, all commit messages.
Reviewable status:complete! all discussions resolved, platform LGTM from [betsymcphail] (waiting on @jwnimmer-tri)
|
+@ggould-tri for platform review, please (and to see a taste of what Anzu will look like). |
|
Oops, I tagged Grant on the wrong PR 🤦 -@ggould-tri. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nobody has volunteered to maintain these, so we must remove them from our support footprint.
Closes #335. Closes #336.
This change is