[drake_bazel_external_legacy] Add as fork of non-legacy repository #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+@BetsyMcPhail for feature review (or delegation), please. |
BetsyMcPhail
approved these changes
Dec 11, 2024
There was a problem hiding this comment.
I confirmed that all the files, with the exception of the README, are listed in the file_sync_test. Also, the new Jenkins job ran and passed.
Reviewed 31 of 31 files at r1, all commit messages.
Reviewable status: 1 unresolved discussion, platform LGTM from [betsymcphail] (waiting on @jwnimmer-tri)
drake_bazel_external_legacy/README.md line 6 at r1 (raw file):
which is deprecated as of Bazel 8 and will be removed in Bazel 9. Therefore, we do not recommend using this example for new projects; instead, refer to the `drake_bazel_external` example. The legacy example primary serves as a
BTW s/primary/primarily
The legacy example will show how to use WORKSPACE. The existing (non-legacy) example will switch to use MODULE soon. At the moment, all sources except README.md must remain identical across the two copies (per the file_sync_test). As we port to use bzlmod, a few files will start to differ and will be removed from the sync.
jwnimmer-tri
force-pushed
the
bazel-legacy
branch
from
c64522c to
335d733
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards RobotLocomotion/drake#20731. This will serve as (nightly) CI of the WORKSPACE mode, because Drake CI will soon be switching to always use bzlmod.
The legacy example will show how to use WORKSPACE. The existing (non-legacy) example will switch to use MODULE soon.
At the moment, all sources except README.md must remain identical across the two copies (per the file_sync_test). As we port to use bzlmod, a few files will start to differ and will be removed from the sync.
This change is