Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coordinator trade pipeline end-to-end tests #934

Merged
merged 14 commits into from
Nov 14, 2023

Conversation

Reckless-Satoshi
Copy link
Collaborator

@Reckless-Satoshi Reckless-Satoshi commented Nov 6, 2023

What does this PR do?

This PR introduces integration tests with end-to-end trades to the coordinator backend.

  • Implement API tests class that asserts all client responses against our OpenAPI specs file.
  • Implement test class with functionality to create robots, create orders, take them etc. Partial work done only, more tests to be introduced.
  • Implement regtest docker-compose testing environment with LND and CLN backend and a user node.
  • Create github wofklow for integration tests that uses matrix strategy for different versions of, LND, CLN, Bitcoin Core and Python for the Django backend

This PR also has some bug fixes and improvements to the API specs done while implementing the firsts integration tests.

Checklist before merging

  • Install pre-commit and initialize it: pip install pre-commit, then pre-commit install. Pre-commit installs git hooks that automatically check the codebase. If pre-commit fails when you commit your changes, please fix the problems it points out.

@Reckless-Satoshi Reckless-Satoshi force-pushed the trade-integration-tests branch 21 times, most recently from e0cb6b6 to dccf88c Compare November 13, 2023 17:11
@Reckless-Satoshi Reckless-Satoshi force-pushed the trade-integration-tests branch 12 times, most recently from 4f6a5ec to 05b2a24 Compare November 13, 2023 23:12
@Reckless-Satoshi Reckless-Satoshi force-pushed the trade-integration-tests branch 7 times, most recently from a233acb to 3c8a437 Compare November 14, 2023 02:30
@Reckless-Satoshi Reckless-Satoshi marked this pull request as ready for review November 14, 2023 13:46
@Reckless-Satoshi Reckless-Satoshi merged commit 281f144 into main Nov 14, 2023
3 checks passed
@Reckless-Satoshi Reckless-Satoshi deleted the trade-integration-tests branch November 14, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant