Store status notifications #1429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KoalaSat
force-pushed
the
store-status-notifications
branch
from
fb4f7c6 to
0022f5b
Compare
Reckless-Satoshi
force-pushed
the
main
branch
2 times, most recently
from
9054b87 to
f9244e1
Compare
KoalaSat
force-pushed
the
store-status-notifications
branch
from
889f333 to
4f2ec02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR introduces and refactors the notifications handling in backend, storing every single status change of the order to help manage better order changes in a future PR. The fact that they are stored with empty title helps to not display them in Android/Web notifications
The refactor also helps to understand when notifications are created
Checklist before merging
pip install pre-commit, thenpre-commit install. Pre-commit installs git hooks that automatically check the codebase. If pre-commit fails when you commit your changes, please fix the problems it points out.