-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split host and port in .env variables #1363
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice proposal! We shouldn't forget about double check if there is any effect on https://github.com/RoboSats/robosats-deploy, since its the software that coordinators run
If we want to add new variables for host/port split into two vars, we need to keep supporting the current variable names with deprecation notice. Re-factoring the Creating a PR in robosats-deploy is not enough: we have to document it (how an existing What is the motivation for splitting host and port into two variables? I agree it's cleaner, but not sure if worth the amount of trouble this upgrade can potentially cause. |
@Reckless-Satoshi yes the coordinators would have to change their |
42e4865
to
5eda999
Compare
5eda999
to
7b3c62e
Compare
9054b87
to
f9244e1
Compare
What does this PR do?
Split host and port in .env variables.
Related to #1364.
Checklist before merging
pip install pre-commit
, thenpre-commit install
. Pre-commit installs git hooks that automatically check the codebase. If pre-commit fails when you commit your changes, please fix the problems it points out.