Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade opentelemetry and remove prometheus dep #49

Merged
merged 12 commits into from
Nov 23, 2024

Conversation

kushudai
Copy link
Contributor

@kushudai kushudai commented Nov 20, 2024

What problem are we solving?

Opentelemery and rust are out of date.
Additionally, the metrics don't work because our version of prometheus is different so the counter and registry types we emit metrics are different for the compiler compared to the one used here.

How are we solving the problem?

Upgrading rust and opentelemetry.
Also switching out to a generic metrics system that is emitted over a channel which we can then plug into whatever metrics library we want.

Checks

Please check these off before promoting the pull request to non-draft status.

  • All CI checks are green.
  • I have reviewed the proposed changes myself.

@kushudai kushudai marked this pull request as ready for review November 22, 2024 23:46
@kushudai kushudai merged commit 76ec354 into main Nov 23, 2024
5 checks passed
@kushudai kushudai deleted the opentelemetry-and-rm-prometheus branch November 23, 2024 00:49
@github-actions github-actions bot locked and limited conversation to collaborators Nov 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants