feat: add cloud device status for LitterBox #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, please revert the changes that you have made to the strings and English translation file as it will break the integration for feeders. Instead, create the device_status (without the on batteries state) as its own key while keeping the feeder_status as it was. Edit: disregard, I missed the commit you made that fixed the issue. |
|
So yes, I chose to reuse "feeder_status" which I renamed to "device_status" to avoid making the code heavier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
State got from "state.pim" key
This information is already used to make the buttons "unavailable" but was not displayed as a sensor