Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: migrate config and add strict validation #15

Merged
merged 1 commit into from
Nov 10, 2023
Merged

feat: migrate config and add strict validation #15

merged 1 commit into from
Nov 10, 2023

Conversation

frantic1048
Copy link
Contributor

@frantic1048 frantic1048 commented Nov 9, 2023 •
edited
Loading

Resolves #13

@frantic1048 frantic1048 force-pushed the feature/add-strict-validation-and-migrate-config branch from dac6917 to 30e4761 Compare November 9, 2023 10:31
@frantic1048 frantic1048 requested a review from liby November 10, 2023 01:49
@frantic1048 frantic1048 mentioned this pull request Nov 10, 2023
Merged
liby
liby reviewed Nov 10, 2023
View reviewed changes
Copy link
Contributor

@liby liby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does default.json include code style changes?

@frantic1048
Copy link
Contributor Author

Why does default.json include code style changes?

The migrated content was produced with renovate-config-validator (e.g. https://github.com/RightCapitalHQ/renovate-config/actions/runs/6725689077/job/18280581408)

Perhaps we could add Prettier for the repo ?

@liby
Copy link
Contributor

liby commented Nov 10, 2023

Yes, but it should not be included in this PR, which could lead people to think it's just a change in code style and ignore major changes:

"config:base" -> "config:recommended"

@frantic1048 frantic1048 force-pushed the feature/add-strict-validation-and-migrate-config branch from 30e4761 to 8b5c82a Compare November 10, 2023 03:20
@liby liby merged commit 42295e1 into main Nov 10, 2023
1 check passed
@liby liby deleted the feature/add-strict-validation-and-migrate-config branch November 10, 2023 03:21
@frantic1048 frantic1048 mentioned this pull request Nov 10, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liby liby liby left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ensure renovate config is up-to-date and do necessary migration for current config
2 participants
@frantic1048 @liby