Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: replace jest with vitest #76

Merged
merged 1 commit into from
Jan 9, 2024
Merged

test: replace jest with vitest #76

merged 1 commit into from
Jan 9, 2024

Conversation

rainx
Copy link
Contributor

@rainx rainx commented Jan 9, 2024 •
edited
Loading

  1. Following @frantic1048 's suggestion, migrate jest to vitest
  2. remove ts-node dependency

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

Before and After

no changes

pnpm test vs pnpm test

@rainx rainx requested a review from frantic1048 January 9, 2024 06:21
@rainx rainx self-assigned this Jan 9, 2024
@rainx rainx added enhancement Enhancement of the code, not introducing new features. ci Work that improves the continuous integration. labels Jan 9, 2024
@rainx rainx requested a review from Yilun-Sun January 9, 2024 06:22
@rainx rainx force-pushed the feature/migrate-jest-to-vitest branch from c92f4c9 to fddc145 Compare January 9, 2024 06:24
@rainx rainx force-pushed the feature/migrate-jest-to-vitest branch from fddc145 to 4b7696d Compare January 9, 2024 06:25
Yilun-Sun
Yilun-Sun approved these changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@Yilun-Sun Yilun-Sun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@rainx rainx merged commit 434980c into main Jan 9, 2024
5 checks passed
@rainx rainx deleted the feature/migrate-jest-to-vitest branch March 8, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yilun-Sun Yilun-Sun Yilun-Sun approved these changes

@frantic1048 frantic1048 Awaiting requested review from frantic1048

Assignees

@rainx rainx

Labels
ci Work that improves the continuous integration. enhancement Enhancement of the code, not introducing new features.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rainx @Yilun-Sun