fix: use isPropertyTagValueNode to filter tag value nodes in comment

RightCapitalHQ · Mar 7, 2024 · 30a08d5 · 30a08d5
1 parent cf14291
commit 30a08d5
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/src/phpdoc-parser/transpiler/README.md b/src/phpdoc-parser/transpiler/README.md
@@ -22,6 +22,7 @@ import { renderTsNodeToString } from './helpers';
 import { PhpDocTypeNodeToTypescriptTypeNodeTranspiler } from './php-doc-to-typescript-type-transpiler';
 import type { ParamTagValueNode, PropertyTagValueNode, ReturnTagValueNode } from '../ast/php-doc';
 import { Lexer, ConstExprParser, PhpDocParser, TokenIterator, TypeParser } from '../lexer/parser';
+import { isPropertyTagValueNode } from '../ast/php-doc/helpers'
 ```
 
 ## Step 2: Define a Custom Transpiler Class
@@ -60,6 +61,7 @@ const getPropertyTagValueNodesFromComment = (commentText: string) => {
   const propertyTagValueNodes = astRootNode
     .getTags()
     .map((node) => node.value)
+    .filter(isPropertyTagValueNode);
 
   return propertyTagValueNodes;
 };

diff --git a/tests/transpiler/transpiler.test.ts b/tests/transpiler/transpiler.test.ts
@@ -9,7 +9,7 @@ import {
   TypeParser,
   PhpDocParser,
   renderTsNodeToString,
-  type PropertyTagValueNode,
+  isPropertyTagValueNode,
 } from '../../src';
 
 class ExtendedTranspiler extends PhpDocTypeNodeToTypescriptTypeNodeTranspiler {
@@ -41,7 +41,8 @@ const getPropertyTagValueNodesFromComment = (commentText: string) => {
   // Extract property, return, or parameter nodes from the AST.
   const propertyTagValueNodes = astRootNode
     .getTags()
-    .map((node) => node.value) as PropertyTagValueNode[];
+    .map((node) => node.value)
+    .filter(isPropertyTagValueNode);
 
   return propertyTagValueNodes;
 };