Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardized the composer file #6

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kayw-geek
Copy link

  • Standardize composer file
  • Ignore commit of lock file
  • Unlock the version of nikic/php-parser

@liby
Copy link
Contributor

liby commented Sep 14, 2023

  • Ignore commit of lock file
  • Unlock the version of nikic/php-parser

Thank you for your contribution. However, the current practice of pinning the version of nikic/php-parser and committing the lock file in the repository is done intentionally for specific reasons.

Pinning the version helps us ensure that all developers and environments are using the exact same version of the dependency, which can help prevent bugs that might occur due to differences in dependency versions.

Including the lock file in the repository ensures that everyone installs the exact same dependencies, which is important for achieving reproducible builds and for ensuring that our application behaves the same way in all environments.

We appreciate your effort, but we would need compelling reasons to change these practices. Could you please explain the benefits of the changes you proposed?

@rainx
Copy link
Contributor

rainx commented Sep 14, 2023

@kayw-geek (Kai) Thanks for contributing. one more thing to clarify. we are using conventional commits on this project. so please read the doc ( https://www.conventionalcommits.org/en/v1.0.0/ ) to see how to write the commit message. if you have Node.JS installed, please run pnpm install to enable Husky. there would be a pre-commit lint to ensure the commit message is correct.

@kayw-geek
Copy link
Author

@liby I don't know if we can accept the change range of the upstream package.
Can it be changed to "nikic/php-parser": "~4.17.1" or "nikic/php-parser": "~4.17" without limiting the patch or minor version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants