WIP: Add Boltz as additional swap provider #361
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is ready to be reviewed once more @saubyk @ShahanaFarooqui @diogorsergio |
Hey guys, will start the review of this PR after the v0.9.1 release. Looking forward to testing it out, soon. |
|
Future Boltz PR updates will be maintained at Branch https://github.com/Ride-The-Lightning/RTL/tree/Boltz |
|
Closing it with PR #590 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP: This PR adds Boltz as an additional swap provider alongside Loop. From UI perspective, Loop in (submarine swaps) and Loop out (reverse submarine swaps) have been renamed as Deposit and Withdrawal respectively, for sake of a more generalized terminology and paving the way for integration of additional swap providers. We welcome any sort of feedback including the ones associated with nomenclature. Boltz differs from Loop in that it doesn't require the user to set up an external daemon, which allowed us to integrate the Boltz API in the RTL directly. We've taken the utmost care to keep the end-user experience the same as that of swapping via Loop. Our decision to adhere to the same UI flow stems from the need to eradicate any user confusion that might come from otherwise different swap flow with different swap providers. We hope to have this PR reviewed, iterated on, and finally get merged into the master branch.
Furthermore, we put out a demo of a self-custodial so-called "channel creation swap" which we plan to offer as an API endpoint soon. We propose that we work on it next to have it added to the RTL. A channel-creation swap integrated into RTL will simplify node management for LN node operators as getting started with LN would be as simple as sending on-chain coins to Boltz and getting a balanced channel back. We'd love to hear your thoughts on it.
TODOs for this WIP PR:
TODOs for next proposed PR: