Force dependence on boto3 credential providers #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kludging a credential provider when they're provided out of the box is poor form. - Since this new method (and technically the old one too) allowed role/temporary credentials, the get_current_user() may have thrown, so this works around that. - Removes all references to explicit credentials, and falls back to the standard AWS credential provider mechanism. - Fixes a bug where the groups marker reference was to an undefined variable (caught in linting) when enumerating groups the user is part of.
Closed
|
+1 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kludging a credential provider when they're provided out of the box is poor form.
Contains a fair number of whitespace-only change due to linting for style done via yapf automagic.