Changed hf iclass view/decrypt to detect SIO lengths better and show if legacy credentials are encrypted #2117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w if legacy credentials are encrypted
|
Excellent! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It now does some super basic parsing of the ASN.1 to determine the length rather than pattern matching. I also feed this information into the block view to correctly highlight the SIO blocks rather than always assuming it's the same number of blocks.
I also added some bounds checking for safety and tweaked the legacy block display to show "HID CFG" for block 6, and "Enc Cred" if the legacy block is encrypted instead of just always showing "Cred".
This fixes the bug mentioned in discord where it would fail to show custom keyed SIOs correctly