Change in behavior of hf mf autopwn when no card is detected #2110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed line 2510 to change DEBUG to ERR Signed-off-by: spandox2 <[email protected]>
Problem: "hf mf autopwn" gave no response if no card was detected, leaving user confused. Solution: Change a DEBUG message to an ERR and give a hint that the card may be poorly positioned. Signed-off-by: spandox2 <[email protected]>
Changed ERR to HINT Signed-off-by: spandox2 <[email protected]>
text change Signed-off-by: spandox2 <[email protected]>
Signed-off-by: spandox2 <[email protected]>
Signed-off-by: spandox2 <[email protected]>
|
You are welcome to add an entry to the CHANGELOG.md as well |
|
Took some time but we got there in the end! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
hf mf autopwnreturns silently when no card is detected. There is a DEBUG message that most people won't seeProposed Solution:
Change the DEBUG to a FAILED and add a HINT