Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crc render position when data len is multiple of 16 #2103

Merged
merged 1 commit into from
Sep 5, 2023
Merged

Conversation

piru
Copy link

@piru piru commented Sep 5, 2023

This fixes crc rendering when data len is multiple of 16. Before you would for example get this when the first char of ANSI escape code would get lost:

   77369536 |   77392704 | Tag |xx  xx  xx  xx  xx  xx  xx  xx  xx  xx  xx  xx  xx  xx  xx  xx  xx  xx   |     | 
            |            |     |[0m yy  yy  

@github-actions
Copy link

github-actions bot commented Sep 5, 2023

You are welcome to add an entry to the CHANGELOG.md as well

@iceman1001 iceman1001 merged commit 8a8c702 into RfidResearchGroup:master Sep 5, 2023
1 check passed
@iceman1001
Copy link
Collaborator

Awesome!

@piru
Copy link
Author

piru commented Sep 6, 2023

@iceman1001 I think this code might not be 100% yet, it likely shifts the output a bit now. The code coloring the output is rather hard to follow. But at least it doesn't omit the ESC code now.

@iceman1001
Copy link
Collaborator

its an improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants