Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve iClass SIO and legacy credential detection reliability #2088

Merged

Conversation

nvx
Copy link
Contributor

@nvx nvx commented Aug 22, 2023

Now relies on the legacy config block for SR detection and the end-of-SIO detection no longer partially cuts off the SIO for any dumps I have.

The previous code would cut off some SIOs mid way through if they happened to contain the wrong bytes mid way through.

Also fixes a couple of super minor display quirks I noticed while running hf iclass view on all my dumps - for example if the stars aligned on a SE dump it could in some cases try and decode block 7 as if it were a legacy dump resulting in rather confusing output, and a case where hf iclass decrypt would attempt to use a card helper even if the flag wasn't set (again if the stars aligned with the right block data).

reliability. Now relies on the legacy config block for SR detection
and the end-of-SIO detection no longer partially cuts off the SIO
for any dumps I have.
@iceman1001 iceman1001 merged commit db7a8e1 into RfidResearchGroup:master Aug 23, 2023
10 of 12 checks passed
@iceman1001
Copy link
Collaborator

Awedsome, there were some interesting fixes, I merge as is.

Feedback,

  • The reverse strstr got me confused. Maybe add a comment about the two functions now in util.c.
  • the SR BIT 0xA0 Should be a MACRO define, to denote what it is.
  • help text for default start 3 and 6, should be in the general description. Otherwise the column text becomes too large (save screen space)

I see you must have had some unsecure tags to play with in order to trigger them :)

@nvx nvx deleted the bugfix/iclass_credential_detection branch August 24, 2023 04:46
@nvx nvx mentioned this pull request Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants