Improve iClass SIO and legacy credential detection reliability #2088
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now relies on the legacy config block for SR detection and the end-of-SIO detection no longer partially cuts off the SIO for any dumps I have.
The previous code would cut off some SIOs mid way through if they happened to contain the wrong bytes mid way through.
Also fixes a couple of super minor display quirks I noticed while running
hf iclass view
on all my dumps - for example if the stars aligned on a SE dump it could in some cases try and decode block 7 as if it were a legacy dump resulting in rather confusing output, and a case wherehf iclass decrypt
would attempt to use a card helper even if the flag wasn't set (again if the stars aligned with the right block data).