Adds hf iclass esetblk, equivalent to hf mf esetblk
#2086
Conversation
Also some minor tweaks to make commands.json and commands.md properly on Windows.
|
You are welcome to add an entry to the CHANGELOG.md as well |
client/src/cmdhficlass.c
Outdated
| static int CmdHFiClassESetBlk(const char *Cmd) { | ||
| CLIParserContext *ctx; | ||
| CLIParserInit(&ctx, "hf iclass esetblk", | ||
| "Display emulator memory.\n" |
There was a problem hiding this comment.
I believe you need to update this texts to match the new command
There was a problem hiding this comment.
Whoops missed that one!
|
Nice fixes, just need the help text to be updated then it can be merged would actually been better with several PR's... |
nvx
force-pushed
the
feature/cmd_iclass_esetblk
branch
from
0586945
to
bc87615
Compare
yeah I thought that afterwards, wasn't intending to fix the commands build stuff but then ended up fighting it as a result of adding the new command and didn't want a thousand line diff because the tooling was doing weird stuff. should be right to merge now that I remembered to regenerate the doc/commands.json after fixing the help text now. |
|
Awesome fixes! |
Also some minor tweaks to make commands.json and commands.md properly on Windows. Previously on windows it would cause a difference vs on Linux due to the case of differences of the serial device.
I also noticed a similar "always makes a diff for every line" with the
pm3line_vocabulary.hdue to a fight between the python script adding a space at the end of each line and the rest of make style removing trailing whitespace on lines.