Make test discovery succeed #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinzenz
force-pushed
the
whatever-mreznik
branch
from
eb3750a to
f007729
Compare
Rezney
reviewed
Jun 16, 2021
| actor = a | ||
| break | ||
|
|
||
| if not actor: | ||
| logger.info("No actor found, exiting collection...") | ||
| print('Node:', collector.nodeid) |
There was a problem hiding this comment.
@vinzenz should we change this to "logger" or is it just a leftover?
|
it's just a leftover
…On Wed, Jun 16, 2021, 15:57 Michal Reznik (mreznik) < ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In conftest.py
<#7 (comment)>:
> actor = a
break
if not actor:
logger.info("No actor found, exiting collection...")
+ print('Node:', collector.nodeid)
@vinzenz <https://github.com/vinzenz> should we change this to "logger"
or is it just a leftover?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#7 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAI6HQ4LS6GWNWD7L4C2ELTTCUU7ANCNFSM46ZNXAWQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.