Primitive multicellular matrix attempt #5673
Conversation
| { | ||
| if (multicellularPositions != null) | ||
| return false; | ||
| GD.Print("olelo"); |
There was a problem hiding this comment.
This one keeps on printing meaning dataSource.MulticellularPositions is null, for some reason
| GenerateMembranePoints(hexPositions, hexCount, membraneType); | ||
| GenerateMembranePoints(hexPositions, hexCount, membraneType, cellPositions, thisCellPosition); | ||
|
|
||
| GD.Print(cellPositions == null); |
There was a problem hiding this comment.
Here it prints false, thus cellPositions is not null
| { | ||
| CacheableDataExtensions.OnCacheHashCollision<MembranePointData>(hash); | ||
| cachedMembrane = null; | ||
|
|
||
| GD.Print("uhm"); |
There was a problem hiding this comment.
And this one keeps on printing, like, constantly. Membrane keeps on re-generating
| @@ -479,6 +484,30 @@ private void GenerateMembranePoints(Vector2[] hexPositions, int hexCount, Membra | |||
| startingBuffer[i] = closestOrganelle + movement; | |||
| } | |||
|
|
|||
| // Multicellular matrix | |||
There was a problem hiding this comment.
Does this approach actually work or (in terms of making a good visual end result)? This is not how I would try to approach the intercellular matrix graphics at all (I'd make a separate mesh or a set of meshes to connect the cells), so I don't really want to spend a bunch of time trying to help debug this approach if it doesn't end up working in the end.
There was a problem hiding this comment.
I can't really tell you if it looks good as I can't get it to work in the first place, that's why I need help, so it's up to you. I don't really like the idea of some filler meshes inbetween cells as it isn't quite clear what such thing is (cell? connective tissue?) but if you really want that, I'm ready to scrap this solution
There was a problem hiding this comment.
I'm not ready to make a decisions on this, but my guess is that stretching the individual membranes will be a very hard to thing to get right. Though we don't know for certain until both approaches are tried as to what they can achieve. Sadly though I don't think it is good use of my limited time right now to try to get the code in this PR working, so that's up to you for now. Or if some other programmer is willing to help, that could be another way this PR gets working.
|
I have added a Voronoi diagram-based vertex manipulation algorithm, so that the vertices projected onto the diagram's edges.
|
Brief Description of What This PR Does
This PR does some stuff...
Related Issues
Progress Checklist
Note: before starting this checklist the PR should be marked as non-draft.
break existing features:
https://wiki.revolutionarygamesstudio.com/wiki/Testing_Checklist
(this is important as to not waste the time of Thrive team
members reviewing this PR)
styleguide.
Before merging all CI jobs should finish on this PR without errors, if
there are automatically detected style issues they should be fixed by
the PR author. Merging must follow our
styleguide.