-
-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added showing patch notes to the main menu #4101
Conversation
which I forgot to do in my previous PR...
but it doesn't show the right patch notes yet
…idental version script on it
…tarting a new game
i took a look into this and, i dunno if its just for me but i works fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I found a few bugs. Other than that (and the UI) I have nothing to comment on. I'm not a steam user so I'm not sure what it looks like when using steam and a packaged built.
Also I wonder if it is preferable to move all those news conversions to our web server, and make the generation script to parse all those notes to its final bbcode state. It's no point to download a number of web pages and spend time parsing them.
Ah, I'm accidentally losing one character in the regex replace call, I'll fix that to include the character that was accidentally removed.
I guess that is possible. Most people use web browsers that try to understand html to display it. The launcher does the exact same thing, it parses HTML. If this was changed in a sensible way, then there'd need to be multiple variants of the data for Thrive and launcher separately. Also going that far, the markdown to bbcode conversion could also be done ahead of time. That is possible but adds the problem that the link clickable colour will be set by the server so if someone wants to change the link colour in Thrive they need to also modify the server software and re-process all the already generated patch notes data. |
Link-clickable color can be set as a placeholder (For example |
Opened follow up issues: #4113 For good measure I also opened an issue for the launcher: Revolutionary-Games/Thrive-Launcher#259 |
Brief Description of What This PR Does
Added displaying patch notes to the main menu on update and added a button in options to view patch notes anytime. There's an option to disable the feature. Also contains small tweaks (and one fix) for the thrive news feed.
Related Issues
closes #3868
closes #3880
Progress Checklist
Note: before starting this checklist the PR should be marked as non-draft.
break existing features:
https://wiki.revolutionarygamesstudio.com/wiki/Testing_Checklist
(this is important as to not waste the time of Thrive team
members reviewing this PR)
styleguide.
Before merging all CI jobs should finish on this PR without errors, if
there are automatically detected style issues they should be fixed by
the PR author. Merging must follow our
styleguide.