Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add check connected address button to searchbar #247

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

kalpovskii
Copy link
Contributor

Issue #246

  • Added “Check connected address” button to search bar

image

Copy link

vercel bot commented Dec 3, 2024

@kalpovskii is attempting to deploy a commit to the Kalis Software Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Dec 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
revoke-cash ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 5, 2024 1:59pm

@rkalis
Copy link
Member

rkalis commented Dec 3, 2024

Hey @kalpovskii, thanks for picking this up, great work!

I have only 2 comments:

1: Right now, the new "Check Connected Wallet" button causes the rest of the page to "shift", see this video:

CleanShot.2024-12-03.at.17.20.02.mp4

In the exploit checker, it renders the button "over" the rest of the page, see this video:

CleanShot.2024-12-03.at.17.20.21.mp4

2: It would be great to have this button on the "token approval checker" page as well, see this video:

CleanShot.2024-12-03.at.17.22.27.mp4

Copy link
Member

@rkalis rkalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice, thank you!

@rkalis rkalis merged commit ce35481 into RevokeCash:master Dec 6, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants