Refactor event types and allowance types #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
rkalis
commented
Nov 28, 2024
rkalis
commented
- Refactor event log types
- Refactor allowance types
- Fix a bug with xdc addresses
- Fewer RPC calls for limited ERC721 approvals
- Add regression tests
- Set tsconfig to "strict" and make required changes
- Remove donate button in 'transaction submitted' toast
- Small fixes and updates
- useEvents now parses raw logs into TokenEvent objects - Further allowance parsing now works on TokenEvent instead of raw logs - Fix bug with xdc addresses - Retrieve token data and allowance data in parallel - Calculate 'limited' NFT allowances from event data
- Update the AllowanceData and related types to match the refactored event types - Set tsconfig "strict" to true + make required changes - Change some null/undefined return / param types - Remove donate button in 'transaction submitted' toast - Expand regression tests - Move some interfaces to more appropriate places Note: this ended up being a way too large commit, note to self to try to not let that happen again 😅
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.