Customer Center DocC updates #4564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonidero
approved these changes
Dec 10, 2024
vegaro
approved these changes
Dec 10, 2024
| @@ -18,10 +18,10 @@ import Foundation | |||
| /// Presentation options to use with the [presentCustomerCenter](x-source-tag://presentCustomerCenter) View modifiers. | |||
| public enum CustomerCenterPresentationMode { | |||
|
|
|||
| /// Customer center presented using SwiftUI's `.sheet`. | |||
| /// Customer Center presented using SwiftUI's `.sheet`. | |||
There was a problem hiding this comment.
I think it should use double backticks?
There was a problem hiding this comment.
The double backticks are used to link to a specific symbol/function. I think we'd need to use the full reference to a specific .sheet function. Since there are multiple .sheet functions, I think it's best to keep it as is and not mention a specific implementation in the docs in case we change it in the future
This was referenced Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up to some comments from #4560 's review and updates some of the Customer Center's DocC documentation. It:
CustomerCenterViewandCustomerCenterViewControllerclass/structs, taken from the public docs here: https://www.revenuecat.com/docs/tools/customer-center#overview