Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds
subscriptions
toCustomerInfo
#4508Adds
subscriptions
toCustomerInfo
#4508Changes from 17 commits
da97daa
3cbefb9
01cd40b
b40eca3
c32aec0
8e67e05
0f10759
088bf60
31dd70c
fd54b5f
60c50d6
2e4ca76
fbb7caa
c93a14d
48fddd8
4b0cd05
0d388c5
a051d9f
ede2484
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small concern but I'm wondering if we should have a
VerificationResult
(from trusted entitlements) here as well, or maybe move the existing one inEntitlementInfos
up to theCustomerInfo
entity... otherwise some devs might use this without checking trusted entitlements...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just checking that we know this is always available, and having it optional was being too defensive?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked in the backend and it's not optional there