Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing @PublicForExternalTesting that broke PaywallsTester #4087

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Add missing @PublicForExternalTesting that broke PaywallsTester #4087

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions RevenueCatUI/Data/TestData.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import SwiftUI
// @PublicForExternalTesting
enum TestData {

// @PublicForExternalTesting
static let customerInfo: CustomerInfo = {
return .decode(
"""
Expand Down Expand Up @@ -149,30 +150,35 @@ enum TestData {
discounts: [],
locale: Self.locale
)
// @PublicForExternalTesting
static let weeklyPackage = Package(
identifier: PackageType.weekly.identifier,
packageType: .weekly,
storeProduct: Self.weeklyProduct.toStoreProduct(),
offeringIdentifier: Self.offeringIdentifier
)
// @PublicForExternalTesting
static let monthlyPackage = Package(
identifier: PackageType.monthly.identifier,
packageType: .monthly,
storeProduct: Self.monthlyProduct.toStoreProduct(),
offeringIdentifier: Self.offeringIdentifier
)
// @PublicForExternalTesting
static let threeMonthPackage = Package(
identifier: PackageType.threeMonth.identifier,
packageType: .threeMonth,
storeProduct: Self.threeMonthProduct.toStoreProduct(),
offeringIdentifier: Self.offeringIdentifier
)
// @PublicForExternalTesting
static let sixMonthPackage = Package(
identifier: PackageType.sixMonth.identifier,
packageType: .sixMonth,
storeProduct: Self.sixMonthProduct.toStoreProduct(),
offeringIdentifier: Self.offeringIdentifier
)
// @PublicForExternalTesting
static let annualPackage = Package(
identifier: PackageType.annual.identifier,
packageType: .annual,
Expand Down Expand Up @@ -205,6 +211,7 @@ enum TestData {
storeProduct: productWithNoIntroOffer.toStoreProduct(),
offeringIdentifier: Self.offeringIdentifier
)
// @PublicForExternalTesting
static let lifetimePackage = Package(
identifier: PackageType.lifetime.identifier,
packageType: .lifetime,
Expand Down Expand Up @@ -770,6 +777,7 @@ extension PaywallColor: ExpressibleByStringLiteral {

extension PackageType {

// @PublicForExternalTesting
var identifier: String {
return Package.string(from: self)!
}
Expand Down
2 changes: 1 addition & 1 deletion Tests/TestingApps/PaywallsTester/PaywallsTester/Config/SamplePaywalls.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

import Foundation
import RevenueCat
@testable import RevenueCatUI
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm I guess if we're adding/removing the public on every build this won't be needed yeah... And it would break uploads to app store connect I imagine.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, that's what was breaking the upload

import RevenueCatUI

import UIKit

Expand Down