-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing @PublicForExternalTesting that broke PaywallsTester #4087
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe
@@ -9,7 +9,7 @@ | |||
|
|||
import Foundation | |||
import RevenueCat | |||
@testable import RevenueCatUI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm I guess if we're adding/removing the public
on every build this won't be needed yeah... And it would break uploads to app store connect I imagine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, that's what was breaking the upload
@tonidero this is still not fixed, because if you notice, most of the stuff in cc: @joshdholtz since this is related to the multi tier PR |
@vegaro @tonidero Oh no! I can take a look at fixing it since I broke it 💪 |
Round 2 on #4087. There were still some stuff not being available to `PaywallsTester` on archive
Round 2 on #4087. There were still some stuff not being available to `PaywallsTester` on archive
It looks like some annotations
PublicForExternalTesting
got removed in https://github.com/RevenueCat/purchases-ios/pull/4022/files#diff-c458d88e52633024e0da56833bdfd34e2790a17f15a9b93ff75dfd7aec02a168, which preventedPaywallsTester
from archivingIt was causing these errors https://github.com/RevenueCat/purchases-ios/runs/27655512796