Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing @PublicForExternalTesting that broke PaywallsTester #4087

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

vegaro
Copy link
Contributor

@vegaro vegaro commented Jul 19, 2024

It looks like some annotations PublicForExternalTesting got removed in https://github.com/RevenueCat/purchases-ios/pull/4022/files#diff-c458d88e52633024e0da56833bdfd34e2790a17f15a9b93ff75dfd7aec02a168, which prevented PaywallsTester from archiving

It was causing these errors https://github.com/RevenueCat/purchases-ios/runs/27655512796

@vegaro vegaro added the build label Jul 19, 2024
@vegaro vegaro requested review from joshdholtz and a team July 19, 2024 11:57
Copy link
Contributor

@tonidero tonidero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe

@@ -9,7 +9,7 @@

import Foundation
import RevenueCat
@testable import RevenueCatUI
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm I guess if we're adding/removing the public on every build this won't be needed yeah... And it would break uploads to app store connect I imagine.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, that's what was breaking the upload

@vegaro vegaro merged commit 0de331f into main Jul 19, 2024
4 checks passed
@vegaro vegaro deleted the fix-paywallstester branch July 19, 2024 12:18
@vegaro
Copy link
Contributor Author

vegaro commented Jul 19, 2024

@tonidero this is still not fixed, because if you notice, most of the stuff in TestData is conditionally compiled on DEBUG... I believe the only solution at the moment is to remove the check for pretty much everything in TestData

cc: @joshdholtz since this is related to the multi tier PR

@joshdholtz
Copy link
Member

@tonidero this is still not fixed, because if you notice, most of the stuff in TestData is conditionally compiled on DEBUG... I believe the only solution at the moment is to remove the check for pretty much everything in TestData

cc: @joshdholtz since this is related to the multi tier PR

@vegaro @tonidero Oh no! I can take a look at fixing it since I broke it 💪

vegaro added a commit that referenced this pull request Jul 19, 2024
Round 2 on #4087. There
were still some stuff not being available to `PaywallsTester` on archive
@fire-at-will fire-at-will mentioned this pull request Jul 23, 2024
nyeu pushed a commit that referenced this pull request Oct 2, 2024
Round 2 on #4087. There
were still some stuff not being available to `PaywallsTester` on archive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants