Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simple optimizations #50

Merged
merged 2 commits into from
Mar 5, 2024
Merged

simple optimizations #50

merged 2 commits into from
Mar 5, 2024

Conversation

bisho
Copy link
Member

@bisho bisho commented Nov 6, 2023

  • Copy prebuilt default flags
  • Use dataclasses with slots instead of nametuples

Before:
multithreaded: Overall: 124463.31 RPS / 8.03 us/req
singlethreaded: Overall: 126979.22 RPS / 7.88 us/req

After:
multithreaded: Overall: 135509.96 RPS / 7.38 us/req
singlethreaded: Overall: 137630.69 RPS / 7.27 us/req

@bisho bisho requested a review from a team November 6, 2023 11:34
@bisho bisho marked this pull request as ready for review November 6, 2023 11:34
@bisho bisho force-pushed the add_non_consistent_hash branch from ec883ec to e5acdfe Compare November 6, 2023 13:30
@bisho bisho force-pushed the simple_optimizations branch from e967449 to 0c4aa30 Compare November 6, 2023 13:30
Copy link

@ethervoid ethervoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL: slots

Copy link

@thecadams thecadams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 what @ethervoid said.. slots!

@bisho bisho force-pushed the add_non_consistent_hash branch from e5acdfe to cede4b3 Compare March 5, 2024 13:31
@bisho bisho force-pushed the simple_optimizations branch from 0c4aa30 to 949da4b Compare March 5, 2024 13:31
@bisho bisho force-pushed the add_non_consistent_hash branch from cede4b3 to d3da834 Compare March 5, 2024 14:09
@bisho bisho force-pushed the simple_optimizations branch from 949da4b to b06fbac Compare March 5, 2024 14:09
@bisho bisho force-pushed the add_non_consistent_hash branch from d3da834 to bc86e86 Compare March 5, 2024 14:12
@bisho bisho force-pushed the simple_optimizations branch from b06fbac to 2fcb57c Compare March 5, 2024 14:12
@bisho bisho force-pushed the simple_optimizations branch from 2fcb57c to dc9536d Compare March 5, 2024 14:13
@bisho bisho changed the base branch from add_non_consistent_hash to main March 5, 2024 14:14
@bisho bisho merged commit 8017a67 into main Mar 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants