♻️ refactor: remove Final from event so that new handlers can be adde…

…d or removed (#29)
RevenueCat · Jun 3, 2022 · 351964c · 351964c
1 parent 7b8ad65
commit 351964c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Changelog
 
+## v0.9.2
+### Fixed
+* `on_write_failure` event handler now can be subscribed/unsubscribed to.
+
 ## v0.9.1
 * Error logging fixes
 

diff --git a/src/meta_memcache/base/base_cache_pool.py b/src/meta_memcache/base/base_cache_pool.py
@@ -2,7 +2,7 @@
 import logging
 from abc import ABC, abstractmethod
 from collections import defaultdict
-from typing import Any, Callable, DefaultDict, Dict, Final, List, Optional, Set, Tuple
+from typing import Any, Callable, DefaultDict, Dict, List, Optional, Set, Tuple
 
 from meta_memcache.base.base_serializer import BaseSerializer
 from meta_memcache.base.connection_pool import ConnectionPool
@@ -40,7 +40,7 @@ def __init__(
     ) -> None:
         self._serializer = serializer
         self._binary_key_encoding_fn = binary_key_encoding_fn
-        self.on_write_failure: Final = WriteFailureEvent()
+        self.on_write_failure = WriteFailureEvent()
 
     @abstractmethod
     def _get_pool(self, key: Key) -> ConnectionPool: