Update JoinTable logic #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mirrored fields logic to remove JoinTable duplicates Removed Validate_Adds_JoinTables test as Validate doesn't add the JoinTables anymore, replaced them with two new validator tests
brianlagunas
requested changes
Oct 9, 2024
src/Reveal.Sdk.Dom.Tests/Core/Utilities/RdashDocumentValidatorFixture.cs
Outdated
Show resolved
Hide resolved
… left and right fieldName Renamed one of the tests to make it adhere to the naming convention
brianlagunas
approved these changes
Oct 9, 2024
brianlagunas
deleted the
remove-duplicates-during-jointables-validation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved JoinTables collection copy from the Validator to the Visualization.UpdateDataSourceItem
Mirrored fields logic to remove JoinTable duplicates during validation
Removed Validate_Adds_JoinTables test, replaced it with two new validator tests