Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored FilterBindings property #63

Merged
merged 2 commits into from
Sep 25, 2024
Merged

Refactored FilterBindings property #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e61adc
moved FilterBindings to base Visualization class
brianlagunas Sep 13, 2024
4c02237
fix tests
brianlagunas Sep 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions e2e/Sandbox/MainWindow.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,8 @@ public partial class MainWindow : Window
{
static readonly string _dashboardFilePath = Path.Combine(Environment.CurrentDirectory, "Dashboards");

readonly string _readFilePath = Path.Combine(_dashboardFilePath, DashboardFileNames.Sales);
//readonly string _readFilePath = Path.Combine(_dashboardFilePath, "My Dashboard.rdash");
//readonly string _readFilePath = Path.Combine(_dashboardFilePath, DashboardFileNames.Sales);
readonly string _readFilePath = Path.Combine(_dashboardFilePath, "New Dashboard.rdash");

readonly string _saveJsonToPath = Path.Combine(_dashboardFilePath, "MyDashboard.json");
readonly string _saveRdashToPath = Path.Combine(_dashboardFilePath, DashboardFileNames.MyDashboard);
Expand Down
8 changes: 8 additions & 0 deletions src/Reveal.Sdk.Dom.Tests/Core/VisualizationCollectionFixture.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
using Reveal.Sdk.Dom.Core;
using Reveal.Sdk.Dom.Data;
using Reveal.Sdk.Dom.Filters;
using Reveal.Sdk.Dom.Visualizations;
using System.Collections.Generic;
using Xunit;
Expand Down Expand Up @@ -108,6 +110,12 @@ private class MockVisualization : IVisualization, IParentDocument
public string Description { get; set; }
public IDataDefinition DataDefinition { get; }
RdashDocument IParentDocument.Document { get; set; }
public List<Binding> FilterBindings { get; }

public DataSourceItem GetDataSourceItem()
{
throw new System.NotImplementedException();
}
}
}
}
Loading
Loading