Merge pull request #64 from RevealBi/change-grid-vizspec-type

Support CategoryVisualizationDataSpec in grids
RevealBi · Sep 25, 2024 · ebcd4f1 · ebcd4f1
2 parents fae5984 + ed2539b
commit ebcd4f1
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/src/Reveal.Sdk.Dom/Data/Enums/DataSourceProvider.cs b/src/Reveal.Sdk.Dom/Data/Enums/DataSourceProvider.cs
@@ -25,6 +25,9 @@ public enum DataSourceProvider
         [EnumMember(Value = "DROPBOXPROVIDER")]
         Dropbox,
 
+        [EnumMember(Value = "GOOGLE_ADS")]
+        GoogleAds,
+
         [EnumMember(Value = "GOOGLE_ANALYTICS")]
         GoogleAnalytics,
 

diff --git a/src/Reveal.Sdk.Dom/Visualizations/GridVisualization.cs b/src/Reveal.Sdk.Dom/Visualizations/GridVisualization.cs
@@ -27,9 +27,18 @@ public GridVisualization(DataSourceItem dataSourceItem) : this(null, dataSourceI
         public GridVisualization(string title, DataSourceItem dataSourceItem) : base(title, dataSourceItem) { ChartType = ChartType.Grid; }
 
         [JsonIgnore]
-        public List<TabularColumn> Columns { get { return VisualizationDataSpec.Columns; } }
+        public List<TabularColumn> Columns { get {
+                if (VisualizationDataSpec is GridVisualizationDataSpec gds)
+                {
+                    return gds.Columns;
+                }
+                else 
+                {
+                    return new List<TabularColumn>();
+                }
+            } }
 
         [JsonProperty(Order = 7)]
-        GridVisualizationDataSpec VisualizationDataSpec { get; set; } = new GridVisualizationDataSpec();
+        VisualizationDataSpec VisualizationDataSpec { get; set; } = new GridVisualizationDataSpec();
     }
 }