Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for Ubuntu 24.04 and debian bookworm #1345

Merged
merged 32 commits into from
Nov 10, 2024
Merged

Conversation

martukas
Copy link
Member

@martukas martukas commented Oct 23, 2024

Description

Updates all software, scripts and document generation tooling to work with Ubuntu 24.04. Apologies for how massive this is. A significant number of lines are the poetry dependency lock files for the python projects.

  • Updates all install scripts for Ubuntu 24.04, which no longer allows to install pip packages system-wide
  • Therefore, poetry-managed python projects have been created for all python scripts, including debug and the document generation scripts
  • Reusable parts of bash scripts factored out
  • Dead link checker is now made available via docker for both - user and CI
  • scripts for wiring and purchasing page generation refactored and made accessible via docs.sh
  • .gitignore contents refactored, moved closer to relevant components
  • A couple more domains that need to be ignored by link checker
  • docs/wiring/power_entry.yml updates to work with new wireviz syntax
  • pio configs updated for new syntax
  • bootstrap and tools (debugger + related python scripts) moved into separate dirs
  • CI scripts updated to work with all of the above
  • Bootstrap scripts updated for new RaspiOS
  • Relevant documentation updated

TESTING

  • CI is passing
  • Deployed controller to v0.3 prototype with ./controller.sh run
  • Entered debugger with ./controller.sh debug
  • Inside debugger, connected to ventilator with device connect auto
  • Ran test scenario with test run dummy. and observed 3-4 breath cycles with IngMar test lung
  • Similar testing with v0.4 fails - flashing appears to work, but debug interface cannot establish communications. There was not much testing with v0.4 previously, i.e. it's not clear that this used to work, so we may not have to consider this to be regression. UPDATE: tested v.04 with old version of software, and indeed it does not work - no integration test produces actuation and debug interface does not work either.
  • Installed fresh RaspiOS and used bootstrap scripts to configure and build all software
  • Ran with GUI on v0.3 and confirmed it works with controller, also ran debugger successfully
  • Ran integration tests successfully

Self-review checklist:

  • Self-review: looked through the Files changed tab, browsed repository in branch
  • Documentation updated - reflects changes in code, electrical or mechanical design
  • Documentation and graphics follow the documentation style guide
  • New content is linked, easily discoverable, does not require too many clicks
  • Follows other relevant parts of contributor wiki
  • PR has a descriptive name
  • Tagged relevant reviewers

Software only:

  • Follows our code style
  • Commented code, particularly in hard-to-understand areas
  • All tests pass - new and old, locally and on CI
  • No new warnings or static check failures
  • Tests that prove fix is effective or new feature works
  • Manual tests are explained, with instructions for reproducing them

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.43%. Comparing base (20104be) to head (c6e3114).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1345   +/-   ##
=======================================
  Coverage   68.43%   68.43%           
=======================================
  Files          81       81           
  Lines        2829     2829           
=======================================
  Hits         1936     1936           
  Misses        893      893           

@martukas martukas marked this pull request as ready for review November 3, 2024 12:07
Copy link
Contributor

@a-vinod a-vinod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the opportunity to review, Martin! Going to use poetry for my projects now.

@martukas martukas changed the title Updates for Ubuntu 24.04 Updates for Ubuntu 24.04 and debian bookworm Nov 10, 2024
@martukas martukas merged commit ec1e567 into master Nov 10, 2024
12 checks passed
@martukas martukas deleted the maintain_ubuntu24 branch November 10, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants