-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regulator, PSOL and pinch valves in assembly #1337
Open
martukas
wants to merge
3
commits into
master
Choose a base branch
from
issue_1252_regulator_assembly
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martukas
changed the title
regulator assembly with bracket and tubing adapters, PSOL and pinch v…
Regulator, PSOL and pinch valves in assembly
Apr 23, 2023
Codecov Report
@@ Coverage Diff @@
## master #1337 +/- ##
=======================================
Coverage 57.53% 57.53%
=======================================
Files 102 102
Lines 3471 3471
Branches 333 333
=======================================
Hits 1997 1997
Misses 1474 1474
Flags with carried forward coverage won't be shown. Click here to find out more. |
6 tasks
martukas
force-pushed
the
issue_1252_regulator_assembly
branch
from
April 25, 2023 03:11
bc56836
to
af80c54
Compare
martukas
force-pushed
the
issue_940_blower_inlet_update
branch
from
April 26, 2023 03:47
9563ada
to
87eb2eb
Compare
martukas
force-pushed
the
issue_1252_regulator_assembly
branch
from
April 26, 2023 07:08
af80c54
to
a807f7c
Compare
martukas
force-pushed
the
issue_1252_regulator_assembly
branch
from
September 11, 2023 02:30
c26894a
to
ceaa4d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This primarily focused on updating and placing the Oxygen pressure regulator assembly, but ended up making minor progress with some other parts. This progress is not intended to provide final solutions to any other tickets, only seeks to move us along and help inform priorities.
Adds new parts:
New assemblies designs
Internals assembly now has preliminary placement of:
Acrylic has not been updated with cuts for protruding parts and hardware.
This helps us evaluate the overall fit of various parts and what else might need to be solved before we can finalize this.
closes #1252
My reccomendation is that following this PR, the following 2 CAD tasks be tackled before we can have a feasible pneumatics assembly design:
I have tagged both as priority.
Self-review checklist:
Files changed
tab, browsed repository in branchCAD / mechanical only: