Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regulator, PSOL and pinch valves in assembly #1337

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

martukas
Copy link
Member

@martukas martukas commented Apr 23, 2023

This primarily focused on updating and placing the Oxygen pressure regulator assembly, but ended up making minor progress with some other parts. This progress is not intended to provide final solutions to any other tickets, only seeks to move us along and help inform priorities.

Adds new parts:

  • regulator mounting bracket - had to be designed from scratch, manufacturer does not provide CAD
  • additional push-to-connect fitting for inlet and PSOL

New assemblies designs

  • new regulator assembly with pneumatic and mechanical interface
  • updates SMC PSOL assembly with new fittings
  • updates pinch valve assembly, simplifying mounting hardware (no washers)

Internals assembly now has preliminary placement of:

  • Regulator
  • PSOL
  • both pinch valves
  • oxygen mixer
  • oxygen sensor and overpressure relief manifold

Acrylic has not been updated with cuts for protruding parts and hardware.

This helps us evaluate the overall fit of various parts and what else might need to be solved before we can finalize this.

closes #1252

My reccomendation is that following this PR, the following 2 CAD tasks be tackled before we can have a feasible pneumatics assembly design:

I have tagged both as priority.

Self-review checklist:

  • Self-review: looked through the Files changed tab, browsed repository in branch
  • Documentation updated - reflects changes in code, electrical or mechanical design
  • Documentation and graphics follow the documentation style guide
  • New content is linked, easily discoverable, does not require too many clicks
  • Follows other relevant parts of contributor wiki
  • PR has a descriptive name
  • Tagged relevant reviewers

CAD / mechanical only:

  • Follows our mechanical engineering standards
  • Everything is metric and ISO where possible
  • All features and constraints are named
  • Imported parts are well-named, with source URL and iProperties
  • Screenshots and/or assembly photos updated

@martukas martukas changed the title regulator assembly with bracket and tubing adapters, PSOL and pinch v… Regulator, PSOL and pinch valves in assembly Apr 23, 2023
@codecov
Copy link

codecov bot commented Apr 23, 2023

Codecov Report

Merging #1337 (ceaa4d9) into master (1f2cabc) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1337   +/-   ##
=======================================
  Coverage   57.53%   57.53%           
=======================================
  Files         102      102           
  Lines        3471     3471           
  Branches      333      333           
=======================================
  Hits         1997     1997           
  Misses       1474     1474           
Flag Coverage Δ
common 95.90% <ø> (ø)
controller 57.37% <ø> (ø)
gui 29.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@martukas martukas force-pushed the issue_1252_regulator_assembly branch from bc56836 to af80c54 Compare April 25, 2023 03:11
@martukas martukas marked this pull request as ready for review April 25, 2023 03:19
@martukas martukas force-pushed the issue_940_blower_inlet_update branch from 9563ada to 87eb2eb Compare April 26, 2023 03:47
Base automatically changed from issue_940_blower_inlet_update to master April 26, 2023 03:59
@martukas martukas force-pushed the issue_1252_regulator_assembly branch from af80c54 to a807f7c Compare April 26, 2023 07:08
@Skizums Skizums self-requested a review May 27, 2023 04:48
@CLAassistant
Copy link

CLAassistant commented Sep 11, 2023

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regulator subassembly for v0.4
2 participants