-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for nullable enums, and improve standalone facets #86
base: master
Are you sure you want to change the base?
Conversation
There are some test keys for this in TooltipConfig that might need to be removed |
I'm pretty sure the last commits broke normal config keys (non-nullable ones) |
I would also like to look at consolidating the enum flags generation since right now there are two methods that do it |
Hmmm, seemed fine when I gave it a quick test, but definitely have a look at it. And yea, consolidating the enum generation would be nice. If you want, you can have a go at creating the "sync bool field with (nullable) enum value" methods that I mentioned in fieldextensions too. They'd basically do what the settings do now. |
The only problem with this now is that you cannot turn off the NONE flag (Flag 0) in the test flag enums. This is likely something wrong in edit: actually that might not be a bug, it might just be how bitflags work |
Yea, ANDing a full zero pattern always matches with the zero pattern in the end. Flags don't need a None option in that sense. |
This works, however there is a bit of semi-duplicated code because the handling for this needs to be slightly different from the normal handling of config keys
Also I'm not sure if these work with the standalone facets (haven't tested it yet)