Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create flexible DataFeedInjector system to allow for arbitrary item injection and result replacement #23

Merged
merged 22 commits into from
Aug 25, 2024

Conversation

Banane9
Copy link
Member

@Banane9 Banane9 commented May 13, 2024

Closes #6 and #9.

@Banane9 Banane9 linked an issue May 13, 2024 that may be closed by this pull request
@Banane9 Banane9 force-pushed the feature/flexible-data-feed-injection branch from f2dabdf to 5f00949 Compare July 18, 2024 22:33
@Banane9 Banane9 force-pushed the feature/flexible-data-feed-injection branch from 5f00949 to 7534226 Compare August 6, 2024 21:19
@Banane9 Banane9 force-pushed the feature/flexible-data-feed-injection branch 2 times, most recently from d03a9b9 to b051804 Compare August 22, 2024 23:20
@Banane9 Banane9 force-pushed the feature/flexible-data-feed-injection branch from 1596147 to 0d54b01 Compare August 23, 2024 22:07
@Banane9 Banane9 requested a review from Nytra August 24, 2024 22:32
@Banane9 Banane9 marked this pull request as ready for review August 24, 2024 22:32
@Banane9 Banane9 added the enhancement New feature or request label Aug 24, 2024
@Banane9
Copy link
Member Author

Banane9 commented Aug 24, 2024

If you want to test this, you also need the latest version of MonkeyLoader - make sure to move the new EnumerableToolkit* dependencies to the Resonite/MonkeyLoader/ folder too

@Banane9 Banane9 requested a review from ColinTimBarndt August 24, 2024 23:18
@Nytra
Copy link
Contributor

Nytra commented Aug 25, 2024

Settings template injection not working

Edit: fixed

@Nytra
Copy link
Contributor

Nytra commented Aug 25, 2024

Requires System.Linq.Async which isn't included with MonkeyLoader

Nytra
Nytra previously requested changes Aug 25, 2024
Copy link
Contributor

@Nytra Nytra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See previous comments

@Nytra
Copy link
Contributor

Nytra commented Aug 25, 2024

Cannot yield to world, origin CoroutineManager is null!

   at void Elements.Core.UniLog.Error(string message, bool stackTrace)
   at void FrooxEngine.NextUpdate.OnCompleted(Action continuation)
   at void System.Runtime.CompilerServices.AsyncTaskMethodBuilder<System.Threading.Tasks.VoidTaskResult>.AwaitOnCompleted<NextUpdate, <<-ctor>b__25_0>d>(ref NextUpdate awaiter, ref <<-ctor>b__25_0>d stateMachine)
   at void System.Runtime.CompilerServices.AsyncTaskMethodBuilder.AwaitOnCompleted<NextUpdate, <<-ctor>b__25_0>d>(ref NextUpdate awaiter, ref <<-ctor>b__25_0>d stateMachine)
   at async MonkeyLoader.Resonite.DataFeeds.Settings.SettingsViewData(SettingsDataFeed dataFeed)+(?) => { }
   at void System.Runtime.CompilerServices.AsyncTaskMethodBuilder.Start<<<-ctor>b__25_0>d>(ref <<-ctor>b__25_0>d stateMachine)
   at MonkeyLoader.Resonite.DataFeeds.Settings.SettingsViewData(SettingsDataFeed dataFeed)+() => { }
   at Task FrooxEngine.ComponentBase<C>.RunSynchronouslyAsync(Action action, bool immediatellyIfPossible)+() => { }
   at void FrooxEngine.World.RunSynchronousActions()
   at void FrooxEngine.World.NextRefreshStage()
   at bool FrooxEngine.World.Refresh()
   at void FrooxEngine.WorldManager.UpdateStep()
   at bool FrooxEngine.WorldManager.RunUpdateLoop()
   at void FrooxEngine.Engine.UpdateStep()
   at void FrooxEngine.Engine.RunUpdateLoop()
   at void UnityFrooxEngineRunner.FrooxEngineRunner.UpdateFrooxEngine()
   at void UnityFrooxEngineRunner.FrooxEngineRunner.Update()

Edit: fixed

@Banane9 Banane9 requested a review from Nytra August 25, 2024 18:59
Copy link
Contributor

@Nytra Nytra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good

@Banane9 Banane9 merged commit 7ed8b12 into master Aug 25, 2024
2 checks passed
@Banane9 Banane9 deleted the feature/flexible-data-feed-injection branch August 25, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants