Upgrade to Go1.19, Golangci-lint v1.48.0, address all linter issues (d…

…apr#5041)

.github/workflows/dapr-perf.yml

@@ -34,7 +34,7 @@ on:
 
 env:
   # Version of Go
-  GOVER: "1.18"
+  GOVER: "1.19"
   # Configure proxy for Go modules
   GOPROXY: https://proxy.golang.org
   # Version of kubectl

.github/workflows/dapr-test.yml

@@ -33,7 +33,7 @@ on:
 
 env:
   # Version of Go
-  GOVER: "1.18"
+  GOVER: "1.19"
   # Configure proxy for Go modules
   GOPROXY: https://proxy.golang.org
   # Version of kubectl

.github/workflows/dapr.yml

@@ -34,8 +34,8 @@ jobs:
     name: Build ${{ matrix.target_os }}_${{ matrix.target_arch }} binaries
     runs-on: ${{ matrix.os }}
     env:
-      GOVER: "1.18"
-      GOLANGCILINT_VER: v1.45.2
+      GOVER: "1.19"
+      GOLANGCILINT_VER: v1.48.0
       PROTOC_VERSION: "21.1"
       GOOS: ${{ matrix.target_os }}
       GOARCH: ${{ matrix.target_arch }}

.github/workflows/kind-e2e.yaml

@@ -51,7 +51,7 @@ jobs:
       DAPR_REGISTRY: localhost:5000/dapr
       DAPR_TAG: dev
       DAPR_NAMESPACE: dapr-tests
-      GOVER: 1.18
+      GOVER: 1.19
       # Container registry where to cache e2e test images
       DAPR_CACHE_REGISTRY: "dapre2eacr.azurecr.io"
       PULL_POLICY: IfNotPresent

.golangci.yml

@@ -4,7 +4,7 @@ run:
   concurrency: 4
 
   # timeout for analysis, e.g. 30s, 5m, default is 1m
-  deadline: 10m
+  deadline: 15m
 
   # exit code when at least one issue was found, default is 1
   issues-exit-code: 1
@@ -30,10 +30,10 @@ run:
   # won't be reported. Default value is empty list, but there is
   # no need to include all autogenerated files, we confidently recognize
   # autogenerated files. If it's not please let us know.
-  skip-files:
+  # skip-files:
   #  - ".*\\.my\\.go$"
   #  - lib/bad.go
-
+  
 # output configuration options
 output:
   # colored-line-number|line-number|json|tab|checkstyle, default is "colored-line-number"
@@ -64,7 +64,7 @@ linters-settings:
 
     # path to a file containing a list of functions to exclude from checking
     # see https://github.com/kisielk/errcheck#excluding-functions for details
-    exclude:
+    # exclude:
 
   funlen:
     lines: 60
@@ -93,6 +93,9 @@ linters-settings:
   golint:
     # minimal confidence for issues, default is 0.8
     min-confidence: 0.8
+  revive:
+    # minimal confidence for issues, default is 0.8
+    confidence: 0.8
   gofmt:
     # simplify code: gofmt with `-s` option, true by default
     simplify: true
@@ -167,7 +170,7 @@ linters-settings:
     # See https://go-critic.github.io/overview#checks-overview
     # To check which checks are enabled run `GL_DEBUG=gocritic golangci-lint run`
     # By default list of stable checks is used.
-    enabled-checks:
+    # enabled-checks:
 
     # Which checks should be disabled; can't be combined with 'enabled-checks'; default is empty
     disabled-checks:
@@ -245,6 +248,7 @@ linters:
     - nestif
     - nlreturn
     - exhaustive
+    - exhaustruct
     - noctx
     - gci
     - golint
@@ -260,7 +264,6 @@ linters:
     - godot
     - cyclop
     - varnamelen
-    - gosec
     - errorlint
     - forcetypeassert
     - ifshort
@@ -272,4 +275,8 @@ linters:
     - wastedassign
     - containedctx
     - gosimple
-    - forbidigo
+    - nonamedreturns
+    - asasalint
+    - rowserrcheck
+    - sqlclosecheck
+    - structcheck

Makefile

@@ -281,8 +281,8 @@ test: test-deps
 # Target: lint                                                                 #
 ################################################################################
 # Due to https://github.com/golangci/golangci-lint/issues/580, we need to add --fix for windows
-# Please use golangci-lint version v1.45.2 , otherwise you might encounter errors.
-# You can download version v1.45.2 at https://github.com/golangci/golangci-lint/releases/tag/v1.45.2
+# Please use golangci-lint version v1.48.0 , otherwise you might encounter errors.
+# You can download version v1.48.0 at https://github.com/golangci/golangci-lint/releases/tag/v1.48.0
 .PHONY: lint
 lint:
 	$(GOLANGCI_LINT) run --timeout=20m
@@ -295,7 +295,7 @@ MODFILES := $(shell find . -name go.mod)
 define modtidy-target
 .PHONY: modtidy-$(1)
 modtidy-$(1):
-	cd $(shell dirname $(1)); go mod tidy -compat=1.18; cd -
+	cd $(shell dirname $(1)); go mod tidy -compat=1.19; cd -
 endef
 
 # Generate modtidy target action for each go.mod file