Fixed bug in redcap2reproschema with items id not matching item filname and redcap variable… #65
Conversation
Evan8456
commented
Jul 11, 2024
Evan8456
commented
- When running redcap2reproschema, the resulting item id's did not match the filename and the variable name on redcap.
Evan8456
changed the title
| @@ -252,18 +252,9 @@ def process_row( | |||
| add_preable=True, | |||
| ): | |||
| """Process a row of the REDCap data and generate the jsonld file for the item.""" | |||
| global matrix_group_count | |||
There was a problem hiding this comment.
can we remove the global variable as well? i don't think this is used anywhere (please do check).
There was a problem hiding this comment.
matrix_group_count was only referenced in the chunk of code I removed, and doesn't show up anywhere else in the project. I think it is safe to remove it now.
There was a problem hiding this comment.
@Evan8456 - there is declaration at the top of the file.
There was a problem hiding this comment.
Sorry, what I meant to say was that now there is no longer a use for matrix_group_count now so I think it is okay to remove the defalcation in addition to the chunk of code I removed earlier. I added a new commit removing the declaration.
There was a problem hiding this comment.
@satra - re matrix_group_count I have not removed the parts related to it, since I understood that we might be using in the near future
There was a problem hiding this comment.
this is something where we need to see an example of to see what we just removed.
