fix header buttons not working on android

workaround from software-mansion/react-native-screens#2219 (comment) software-mansion/react-native-screens#2466
RelistenNet · Dec 23, 2024 · d090a77 · d090a77
1 parent 017acff
commit d090a77
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 6 deletions.
diff --git a/...isten/tabs/(artists,myLibrary)/[artistUuid]/show/[showUuid]/source/[sourceUuid]/index.tsx b/...isten/tabs/(artists,myLibrary)/[artistUuid]/show/[showUuid]/source/[sourceUuid]/index.tsx
@@ -15,7 +15,7 @@ import { MaterialIcons } from '@expo/vector-icons';
 import { Link, useLocalSearchParams, useNavigation } from 'expo-router';
 import React, { PropsWithChildren, useCallback, useEffect } from 'react';
 import { List as ListContentLoader } from 'react-content-loader/native';
-import { Animated, ScrollViewProps, View } from 'react-native';
+import { Animated, ScrollViewProps, TouchableOpacity, View } from 'react-native';
 import * as R from 'remeda';
 
 import { SourceSets } from '@/relisten/components/source/source_sets_component';
@@ -143,7 +143,9 @@ export default function Page() {
     navigation.setOptions({
       title: show?.displayDate,
       headerRight: () => (
-        <MaterialIcons name="more-horiz" color="white" size={22} onPress={onDotsPress} />
+        <TouchableOpacity onPressOut={onDotsPress}>
+          <MaterialIcons name="more-horiz" color="white" size={22} />
+        </TouchableOpacity>
       ),
     });
   }, [show]);

diff --git a/relisten/components/favorite_icon_button.tsx b/relisten/components/favorite_icon_button.tsx
@@ -52,6 +52,6 @@ export const FavoriteObjectButton = <T extends FavoritableObject>({
   }, [object, forceUpdate]);
 
   return (
-    <FavoriteIconButton isFavorited={object.isFavorite} onPress={favoriteOnPress} {...props} />
+    <FavoriteIconButton isFavorited={object.isFavorite} onPressOut={favoriteOnPress} {...props} />
   );
 };
diff --git a/relisten/player/ui/player_screen.tsx b/relisten/player/ui/player_screen.tsx
@@ -393,7 +393,7 @@ export function PlayerScreen() {
       headerLeft: () => {
         return (
           <TouchableOpacity
-            onPress={() => {
+            onPressOut={() => {
               navigation.goBack();
             }}
             className="py-2 pr-2"
@@ -405,7 +405,7 @@ export function PlayerScreen() {
       headerRight: () => {
         return (
           <TouchableOpacity
-            onPress={() => {
+            onPressOut={() => {
               navigation.goBack();
 
               router.push({

diff --git a/relisten/util/logging.ts b/relisten/util/logging.ts
@@ -10,7 +10,10 @@ export const log = logger.createLogger<LogLevels>({
   // TODO: when we have entry, also log to a file so that we can attach it to crash reports
   transport: [consoleTransport, crashlyticsTransport],
   transportOptions: {
-    CRASHLYTICS: crashlyticsModule,
+    CRASHLYTICS: {
+      recordError: (msg: string) => crashlyticsModule.log(msg),
+      log: (msg: string) => crashlyticsModule.log(msg),
+    },
   },
   severity: __DEV__ ? 'debug' : 'info',
   async: true,