Skip to content
This repository has been archived by the owner on Jul 26, 2024. It is now read-only.

Commit

Permalink
Change Node versions in workflows, 14 does not work
Browse files Browse the repository at this point in the history
Signed-off-by: Release-Candidate <[email protected]>
  • Loading branch information
Release-Candidate committed Jul 16, 2023
1 parent 2056ec7 commit 1c879ae
Show file tree
Hide file tree
Showing 2 changed files with 57 additions and 58 deletions.
64 changes: 32 additions & 32 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,37 +10,37 @@
name: Lint

on:
push:
branches: ["main"]
pull_request:
branches: ["main"]
push:
branches: ["main"]
pull_request:
branches: ["main"]

jobs:
eslint:
strategy:
matrix:
os: [ubuntu-latest]
node-version: [14.x, 16.x, 18.x]

runs-on: ${{ matrix.os }}

steps:
- name: Checkout
uses: actions/checkout@v3

- name: Setup Node
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}

- name: Eslint
run: |
yarn --ignore-engines install --dev
yarn --ignore-engines lint-github
- name: Annotate Code Linting Results
uses: ataylorme/eslint-annotate-action@v2
if: ${{ always() }}
with:
repo-token: "${{ secrets.GITHUB_TOKEN }}"
report-json: "eslint_report.json"
eslint:
strategy:
matrix:
os: [ubuntu-latest]
node-version: [16.x, 18.x, 20.x]

runs-on: ${{ matrix.os }}

steps:
- name: Checkout
uses: actions/checkout@v3

- name: Setup Node
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}

- name: Eslint
run: |
yarn --ignore-engines install --dev
yarn --ignore-engines lint-github
- name: Annotate Code Linting Results
uses: ataylorme/eslint-annotate-action@v2
if: ${{ always() }}
with:
repo-token: "${{ secrets.GITHUB_TOKEN }}"
report-json: "eslint_report.json"
51 changes: 25 additions & 26 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,34 +7,33 @@
#
# ==============================================================================


name: Test

on:
push:
branches: ["main"]
pull_request:
branches: ["main"]
push:
branches: ["main"]
pull_request:
branches: ["main"]

jobs:
tests:
strategy:
matrix:
os: [ubuntu-latest]
node-version: [16.x, 18.x]

runs-on: ${{ matrix.os }}

steps:
- name: Checkout
uses: actions/checkout@v3

- name: Setup Node
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}

- name: Run Tests
run: |
yarn --ignore-engines install --dev
xvfb-run -a yarn --ignore-engines test
tests:
strategy:
matrix:
os: [ubuntu-latest]
node-version: [16.x, 18.x, 20.x]

runs-on: ${{ matrix.os }}

steps:
- name: Checkout
uses: actions/checkout@v3

- name: Setup Node
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}

- name: Run Tests
run: |
yarn --ignore-engines install --dev
xvfb-run -a yarn --ignore-engines test

0 comments on commit 1c879ae

Please sign in to comment.