Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RAI-16267 Removed unnecessary dependencies, picked newer versions of dependencies #136

Merged
merged 3 commits into from
Oct 11, 2023

Conversation

antikus
Copy link
Contributor

@antikus antikus commented Sep 14, 2023

Although the versions of the dependencies picked based on the availability of them in Anaconda Snowflake channel ensuing the versions availability in Anaconda Snowflake channel will likely become unnecessary since the Snowflake-friendly version of the SDK will likely be distributed as a separate package so all the existing dependencies versions won't matter in case of SF and vice versa.

@antikus antikus changed the base branch from main to snowpark-friendly-python-sdk September 15, 2023 19:05
@antikus antikus changed the base branch from snowpark-friendly-python-sdk to main October 9, 2023 17:47
@antikus antikus marked this pull request as ready for review October 9, 2023 17:47
Copy link

@stanislav-bedunkevich stanislav-bedunkevich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@antikus antikus changed the title RAI-16267 Removed unnecessary dependencies, picked versions that are available in anaconda sf channel RAI-16267 Removed unnecessary dependencies, picked newer versions of dependencies Oct 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@antikus should we update classifiers in setup.py since SDK won't support Python 3.7?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, it's not the case. The SDK works on 3.7. Initially when I was cleaning up the dependencies and was planning to have snowflake-snowpark-python package as a dependency that would make 3.7 not supportable since the snoflakw library requires Python >=3.8

@antikus antikus merged commit 9a58f83 into main Oct 11, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants