Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a backport error in PR 187 #197

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Fix a backport error in PR 187 #197

merged 1 commit into from
Nov 5, 2024

Conversation

kpamnany
Copy link
Collaborator

@kpamnany kpamnany commented Nov 5, 2024

PR Description

Correctly recognize --trace-compile-timing.

Checklist

Requirements for merging:

  • I have opened an issue or PR upstream on JuliaLang/julia: <link to JuliaLang/julia>
  • I have removed the port-to-* labels that don't apply.
  • I have opened a PR on raicode to test these changes:

@github-actions github-actions bot added port-to-v1.10 This change should apply to Julia v1.10 builds port-to-master This change should apply to all future Julia builds labels Nov 5, 2024
d-netto
d-netto approved these changes Nov 5, 2024
View reviewed changes
Copy link
Member

@d-netto d-netto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kpamnany kpamnany merged commit 8fe069c into v1.10.2+RAI Nov 5, 2024
2 checks passed
@kpamnany kpamnany deleted the kp-fix-187 branch November 5, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-netto d-netto d-netto approved these changes

Assignees
No one assigned
Labels
port-to-master This change should apply to all future Julia builds port-to-v1.10 This change should apply to Julia v1.10 builds
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kpamnany @d-netto