Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update format to use JSON vector for relational appl constraint args #21

Merged
merged 1 commit into from
Nov 18, 2023

Conversation

chriscoey
Copy link
Member

No description provided.

Copy link
Member

@bachdavi bachdavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

This is a breaking change to our format though. As long as we are experimental I think that is fine. We need to be careful to properly synchronize this with the solver service deployment and solverapi.rel

@chriscoey
Copy link
Member Author

fortunately no one is using the relational appl type constraints at the moment, and none of the sample or solve tests do either (though in future we will add some), only model tests (which don't use solverapi.jl).

@chriscoey
Copy link
Member Author

https://github.com/RelationalAI/raicode/pull/16373 merged so I'll merge this too.

@chriscoey chriscoey merged commit 0daca31 into main Nov 18, 2023
3 checks passed
@chriscoey chriscoey deleted the cdc-relappl-vec branch November 18, 2023 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants