Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style RefreshToken URL as <code> in the OAuthFlow #2397

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

ckszabi
Copy link
Contributor

@ckszabi ckszabi commented Aug 30, 2023

Represent refreshToken URL in a similar fashion like Token URL is styled, for consistency in rendering.

What/Why/How?

When an OAuth security scheme definition is rendered the refreshToken URL is presented as plain text, but it should be a (non-clickable) URL, rendered via <code> tag, as the tokenURL is rendered.
One line of template is changed

Reference

Tests

Screenshots (optional)

the wrong rendering:
image

better rendering:
image

Check yourself

  • Code is linted
  • Tested
  • All new/updated code is covered with tests

…on like Token URL is styled, for consistency in rendering.
@ckszabi ckszabi marked this pull request as ready for review August 30, 2023 09:48
@ckszabi ckszabi requested a review from a team as a code owner August 30, 2023 09:48
@AlexVarchuk
Copy link
Collaborator

Hi @ckszabi, thank you for the contribution 🙌

@AlexVarchuk AlexVarchuk merged commit 1d61001 into Redocly:main Sep 11, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants