Skip to content
This repository has been archived by the owner on Jul 20, 2023. It is now read-only.

Update click from 6.7 to 8.0.0 #76

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Avey777
Copy link

@Avey777 Avey777 commented Jun 23, 2023

What type of PR is this?

  • Refactor
  • Feature
  • Bug Fix
  • New Query Runner (Data Source)
  • New Alert Destination
  • Other

Description

I want to know what happened here

How is this tested?

  • Unit tests (pytest, jest)
  • E2E Tests (Cypress)
  • Manually
  • N/A

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

@justinclift
Copy link
Member

The backend-unit-tests job failed with a Docker 403 error when it was trying to pull an image.

That's probably some temporary problem with the Docker repos, so I've just cancelled the rest of the test run and restart it.

@justinclift
Copy link
Member

Hmmm, now it's throwing a different error.

I'm going to rebase this PR onto the very latest commit for our master branch, and see if that changes anything.

@justinclift
Copy link
Member

Hmmm, lets see if less of a jump works. I'll update this with some click versions prior to 8, and lets see what happens. There's also versions 8.1.x too, which might be useful (though doubtful).

@Avey777
Copy link
Author

Avey777 commented Jun 23, 2023

It is also necessary to upgrade click to version 8.0. The 8.0 version runs fine locally, but it is currently failing our tests. I will need your help to resolve this issue.
@justinclift

@justinclift
Copy link
Member

No worries. I can't look at this one right away, as I'm doing other stuff atm.

I'll be able to look at it tomorrow some time, or maybe tonight. Not sure yet.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants