Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use sampler for rosa cli #55

Merged
merged 11 commits into from
Jun 6, 2023
Merged

Use sampler for rosa cli #55

merged 11 commits into from
Jun 6, 2023

Conversation

oharan2
Copy link
Contributor

@oharan2 oharan2 commented May 31, 2023

Tracking this issue for a permanent solution

@redhat-qe-bot
Copy link
Collaborator

Report bugs in Issues

The following are automatically added:

  • Add reviewers from OWNER file (in the root of the repository) under reviewers section.
  • Set PR size label.
  • New issue is created for the PR. (Closed when PR is merged/closed)
    *Run pre-commit if .pre-commit-config.yaml exists in the repo.

Available user actions:

  • To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
    verified label removed on each new commit push.
  • To cherry pick a merged PR comment /cherry-pick <target branch to cherry-pick to> in the PR.
    • Support only merged PRs
  • To re-run tox comment /tox in the PR.
  • To re-run build-container command /build-container in the PR.
  • To build and push container image command /build-and-push-container in the PR (tag will be the PR number).
  • To re-run python-module-install command /python-module-install in the PR.
  • To add a label by comment use /<label name>, to remove, use /<label name> cancel
Supported labels
  • hold
  • verified
  • wip
  • lgtm
  • approve
  • target-version-

@redhat-qe-bot redhat-qe-bot requested review from myakove and rnetser May 31, 2023 17:31
@redhat-qe-bot redhat-qe-bot mentioned this pull request May 31, 2023
Closed
@oharan2 oharan2 force-pushed the rosa_sampler branch 3 times, most recently from 64ff682 to 0582191 Compare May 31, 2023 17:35
oharan2
oharan2 commented Jun 1, 2023
View reviewed changes
ocm_python_wrapper/cluster.py Outdated Show resolved Hide resolved
@oharan2 oharan2 changed the title WIP: Use sampler for rosa cli Use sampler for rosa cli Jun 4, 2023
myakove
myakove requested changes Jun 4, 2023
View reviewed changes
ocm_python_wrapper/cluster.py Outdated Show resolved Hide resolved
ocm_python_wrapper/cluster.py Outdated Show resolved Hide resolved
@redhat-qe-bot redhat-qe-bot requested a review from myakove June 4, 2023 14:22
myakove
myakove requested changes Jun 5, 2023
View reviewed changes
ocm_python_wrapper/cluster.py Outdated Show resolved Hide resolved
@redhat-qe-bot redhat-qe-bot requested a review from myakove June 5, 2023 18:48
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@oharan2
Copy link
Contributor Author

oharan2 commented Jun 5, 2023

/verified

@myakove myakove merged commit 70da58c into RedHatQE:main Jun 6, 2023
@oharan2 oharan2 mentioned this pull request Jun 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@myakove myakove myakove approved these changes

@rnetser rnetser Awaiting requested review from rnetser

Assignees

@oharan2 oharan2

Labels
Approved-by-myakove branch-main can-be-merged size/S verified
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oharan2 @redhat-qe-bot @myakove