Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: store timestamp of last change of given repository #1049

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

yungbender
Copy link

@yungbender yungbender commented Oct 16, 2023

Description

Lets store the last change of every repository done by vmaas. So that in vmaas-sync for Patch/Vulnerability, we can use this timestamp instead of "revision" timestamp for modified_since parameter. Since the revision timestamp is not in "our hands" to modify and by this new timestamp we can detect timestamp when repo changed in vmaas (and not in RedHat CDN).

Secure Coding Practices Checklist GitHub Link

Secure Coding Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

@jira-linking
Copy link

jira-linking bot commented Oct 16, 2023

Referenced Jiras:
https://issues.redhat.com/browse/RHINENG-2608

@yungbender yungbender force-pushed the last_change branch 8 times, most recently from fea14e1 to 372b798 Compare October 16, 2023 14:46
@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

see 47 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@jdobes
Copy link
Member

jdobes commented Oct 17, 2023

/retest

@jdobes jdobes merged commit d2efc4b into RedHatInsights:master Oct 18, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants