Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new info about tags, edited tiles to cards, other small edits #262

Merged
merged 5 commits into from
Nov 6, 2024

Conversation

dayleparker
Copy link
Collaborator

@dayleparker dayleparker commented Oct 18, 2024

Added new info about tags, edited the term 'tiles' to 'cards' (following a Slack conversation between UXD & CCS), other small edits like a reminder step to review content against the Best Practices list.

Jira: https://issues.redhat.com/browse/HCCDOC-3142

@Hyperkid123 would you mind reviewing to catch any errors in the tags section? Also I want to separate the sections for each tag a bit better, any ideas how to improve the markdown?

I will request a review from a content creator as well to make sure the updates make sense.

Thank you!

@app-sre-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@Hyperkid123
Copy link
Collaborator

/ok-to-test

Copy link
Collaborator

@Hyperkid123 Hyperkid123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems great.

Copy link
Contributor

@CodeDuchess CodeDuchess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, Dayle just a few comments.

docs/quickstarts/README.md Outdated Show resolved Hide resolved
docs/quickstarts/README.md Show resolved Hide resolved
docs/quickstarts/README.md Show resolved Hide resolved
docs/quickstarts/README.md Outdated Show resolved Hide resolved
@Hyperkid123 Hyperkid123 requested a review from a team October 29, 2024 10:00
@dayleparker dayleparker changed the title [DRAFT] Added new info about tags, edited tiles to cards, other small edits Added new info about tags, edited tiles to cards, other small edits Oct 31, 2024
@Hyperkid123
Copy link
Collaborator

/retest

@Hyperkid123
Copy link
Collaborator

Sorry about the CI failures. Konflux has been having some issues in the last few days

Copy link
Contributor

@florkbr florkbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@JetyAdam FYI

@florkbr
Copy link
Contributor

florkbr commented Nov 4, 2024

/retest

@Hyperkid123
Copy link
Collaborator

/ok-to-test

@Hyperkid123
Copy link
Collaborator

/retest

@dayleparker
Copy link
Collaborator Author

Thank you for approving it, @florkbr! Can you please merge it as well? (It seems to be blocked by some auto checks)
Let me know if there's anything I need to do from my side.

@Hyperkid123 Hyperkid123 merged commit 5475210 into RedHatInsights:main Nov 6, 2024
8 of 9 checks passed
@dayleparker dayleparker deleted the README-tags branch November 6, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants