Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHCLOUD-35506: Update openapi spec with new params #252

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

JetyAdam
Copy link
Contributor

@JetyAdam JetyAdam commented Sep 26, 2024

@JetyAdam JetyAdam requested review from a team and florkbr September 26, 2024 11:33
@florkbr
Copy link
Contributor

florkbr commented Sep 30, 2024

@JetyAdam just confirming - is this the result of running make generate-spec? https://github.com/RedHatInsights/quickstarts/blob/main/Makefile#L24

@florkbr
Copy link
Contributor

florkbr commented Sep 30, 2024

@JetyAdam this will be a breaking change for anyone who uses the bundle param. Do we know if it is used anywhere else? It might be better to mark it deprecated and then remove it after some time has passed if we are unsure.

Past that - I believe the tests are failing in the pipeline:

[0.404ms] [rows:1] UPDATE `quickstarts` SET `created_at`="2024-09-30 14:04:19.861",`updated_at`="2024-09-30 14:04:19.862",`deleted_at`=NULL,`name`="rhel-quickstart",`content`="{\"tags\": \"rhel\"}" WHERE `quickstarts`.`deleted_at` IS NULL AND `id` = 5
14:04:21 --- FAIL: TestGetAll (0.01s)
14:04:21     --- FAIL: TestGetAll/should_get_all_quickstarts_with_'rbac'_application_tag (0.00s)
14:04:21         quickstarts_test.go:158: 
14:04:21             	Error Trace:	/src/mypackage/myapp/pkg/routes/quickstarts_test.go:158
14:04:21             	Error:      	Not equal: 
14:04:21             	            	expected: 2
14:04:21             	            	actual  : 1
14:04:21             	Test:       	TestGetAll/should_get_all_quickstarts_with_'rbac'_application_tag
14:04:21         quickstarts_test.go:159: 
14:04:21             	Error Trace:	/src/mypackage/myapp/pkg/routes/quickstarts_test.go:159
14:04:21             	Error:      	Not equal: 
14:04:21             	            	expected: "tagged-quickstart"
14:04:21             	            	actual  : "rbac-quickstart"
14:04:21             	            	
14:04:21             	            	Diff:
14:04:21             	            	--- Expected
14:04:21             	            	+++ Actual
14:04:21             	            	@@ -1 +1 @@
14:04:21             	            	-tagged-quickstart
14:04:21             	            	+rbac-quickstart
14:04:21             	Test:       	TestGetAll/should_get_all_quickstarts_with_'rbac'_application_tag

@JetyAdam
Copy link
Contributor Author

JetyAdam commented Oct 1, 2024

The bundle tag is used in certain places, therefore we are keeping it.

@florkbr florkbr changed the title Update openapi spec with new params RHCLOUD-35506: Update openapi spec with new params Oct 1, 2024
@florkbr
Copy link
Contributor

florkbr commented Oct 1, 2024

@JetyAdam looks good. FYI I created a JIRA for this and updated the PR title and description - we should try to track our work via JIRA whenever possible (and for auditing if there are any issues in the future).

@JetyAdam JetyAdam merged commit 987a60b into RedHatInsights:main Oct 1, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants